Supportlink: who edits the ADT stuff?

[Deskin, Bob]

I will forward your comments to the SupportLink editor.

Bob

-----Original Message-----
From: Pickering, John (NORBORD) [mailto:PICKERIJ@norbord.com]
Sent: Thursday, May 03, 2001 3:41 PM
To: 'Deskin, Bob'
Cc: 'Powerhouse List'
Subject: Supportlink: who edits the ADT stuff?


Mr. Deskin

<rant>

Please take a look at page 67 of the just arrived (on my desk anyway)
Supportlink volume 11 number 2, April - June 2001.

This is the sort of extravagant code that looks important but half of it is
unnecessary! The kind of stuff one inherits from others and spends heaps of
time wading through the muck trying to find the pony. Not a really brilliant
example of PowerHouse code for such an august publication :-(

Why test ACCESSOK in the statement after the WHILE RETRIEVING? This verb
will execute the statement after it ONLY if it retrieves a record. A simple
BEGIN...END would be much clearer!

And since ACCESSOK will always be false when you read to the end of file or
read all the values for a single key, it seems kind of pointless to test it.
Lose this one too!

And since t_bill_no will always have the last value retrieved (or the
initial value if the file is empty), why not simply pass it? There seems
little point in moving it to another temporary item! Or use the t_final_xxx
temporary items inside the WHILE RETRIEVING loop.

And for those who don't like unnecessary compile time warnings such as "*W*
the PRIMARY file is missing." you should probably use the SCREEN statement
MENU option.

And I won't even start on what the user will be presented with upon return
from the lower level screen!

Sheesh!

</rant>

Regards,
JWP

= = = = = = = = = = = = = = = = = = = = = = = = = = = =
Mailing list: powerh-l@lists.swau.edu
Subscribe: "subscribe" in message body to powerh-l-request@lists.swau.edu
Unsubscribe: "unsubscribe" in message body to
powerh-l-request@lists.swau.edu
http://lists.swau.edu/mailman/listinfo/powerh-l
This list is closed, thus to post to the list you must be a subscriber.